fix(git-node): check the tag signature and not the commit one#907
Merged
aduh95 merged 1 commit intonodejs:mainfrom Mar 1, 2025
Merged
fix(git-node): check the tag signature and not the commit one#907aduh95 merged 1 commit intonodejs:mainfrom
aduh95 merged 1 commit intonodejs:mainfrom
Conversation
During release promotion, we want to verify the tag is signed with one of the releasers' key. The commit can be signed with a different signature (e.g. the bot's, or a soon-to-be releaser).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
- Coverage 80.05% 79.86% -0.19%
==========================================
Files 39 39
Lines 4673 4684 +11
==========================================
Hits 3741 3741
- Misses 932 943 +11 ☔ View full report in Codecov by Sentry. |
Member
|
The commit message makes me suspicious. The commit signature should have been good in my case as I had to rebase the PR locally. |
Contributor
Author
|
Yeah that's because we're getting the |
targos
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During release promotion, we want to verify the tag is signed with one of the releasers' key. The commit can be signed with a different signature (e.g. the bot's, or a soon-to-be releaser).